Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add I18n locale strings for demo app (en only) #227

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Add I18n locale strings for demo app (en only) #227

wants to merge 4 commits into from

Conversation

myabc
Copy link

@myabc myabc commented Jan 17, 2025

What are you trying to accomplish?

Copies a small subset of locale strings from @opf/openproject (en only) to the demo app for improved previews when running the lookbook locally and more accurate visual regression tests/screenshots.

Screenshots

Before

Screenshot 2025-01-17 at 00 50 09 Screenshot 2025-01-17 at 00 49 59

After

Screenshot 2025-01-17 at 00 47 25 Screenshot 2025-01-17 at 00 47 48

Integration

List the issues that this change affects.

Closes # (type the GitHub issue number after #)

Risk Assessment

  • Low risk the change is small, highly observable, and easily rolled back.
  • Medium risk changes that are isolated, reduced in scope or could impact few users. The change will not impact library availability.
  • High risk changes are those that could impact customers and SLOs, low or no test coverage, low observability, or slow to rollback.

What approach did you choose and why?

@HDinger I've changed my mind a bit on this issue - I think the cost of having to maintain separate I18n strings in this repo is probably pretty small. It brings the advantage of better DX when working oninthe lookbook locally, as well as better screenshots.

Anything you want to highlight for special attention from reviewers?

Accessibility

  • Fixes axe scan violation - This change fixes an existing axe scan violation.
  • No new axe scan violation - This change does not introduce any new axe scan violations.
  • New axe violation - This change introduces a new axe scan violation. Please describe why the violation cannot be resolved below.

Merge checklist

  • Added/updated tests
  • Added/updated documentation
  • Added/updated previews (Lookbook)
  • Tested in Chrome
  • Tested in Firefox
  • Tested in Safari
  • Tested in Edge

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 17, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: a5ef4c8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@openproject/primer-view-components Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions GitHub Actions
Copy link

Uh oh! @myabc, at least one image you shared is missing helpful alt text. Check your pull request body to fix the following violations:
  • Images should have meaningful alternative text (alt text) at line 9
  • Images should have meaningful alternative text (alt text) at line 10
  • Images should have meaningful alternative text (alt text) at line 14
  • Images should have meaningful alternative text (alt text) at line 15

Alt text is an invisible description that helps screen readers describe images to blind or low-vision users. If you are using markdown to display images, add your alt text inside the brackets of the markdown image.

Learn more about alt text at Basic writing and formatting syntax: images on GitHub Docs.

🤖 Beep boop! This comment was added automatically by github/accessibility-alt-text-bot.

@myabc myabc mentioned this pull request Jan 17, 2025
Merged
@myabc myabc added the work in progress Do not merge without further discussion label Feb 17, 2025
myabc added 3 commits February 23, 2025 17:25
@myabc
Add I18n locale strings for demo app (en only)
d41bb7a 
Copies a small subset of locale strings from @opf/openproject (en only)
to the demo app for improved previews when running the lookbook locally
and more accurate visual regression tests/screenshots.
@myabc
Create changeset
ada74f7
@myabc
Update DangerDialog test to use I18n strings
1f4a308
@myabc myabc force-pushed the feature/demo-app-i18n-support branch from 818d019 to 1f4a308 Compare February 23, 2025 20:31
@github-actions GitHub Actions
Copy link

⚠️ Visual or ARIA snapshot differences found

Our visual and ARIA snapshot tests found UI differences. Please review the differences by viewing the files changed tab to ensure that the changes were intentional.

Review differences

@myabc myabc removed the work in progress Do not merge without further discussion label Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliverguenther oliverguenther Awaiting requested review from oliverguenther

@bsatarnejad bsatarnejad Awaiting requested review from bsatarnejad

Assignees
No one assigned
Labels
patch release
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@myabc